From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTP id C704B85D for ; Fri, 23 May 2014 06:21:38 +0000 (UTC) Received: from bedivere.hansenpartnership.com (bedivere.hansenpartnership.com [66.63.167.143]) by smtp1.linuxfoundation.org (Postfix) with ESMTP id CBEC61FAB5 for ; Fri, 23 May 2014 06:21:37 +0000 (UTC) Message-ID: <1400826095.2259.38.camel@dabdike.int.hansenpartnership.com> From: James Bottomley To: Geert Uytterhoeven Date: Thu, 22 May 2014 23:21:35 -0700 In-Reply-To: References: <20140521201108.76ab84af@notabene.brown> <2980546.hqgiQV7seV@vostro.rjw.lan> <20140522154859.GA28971@thunk.org> <20140522203103.GM15585@mwanda> Content-Type: text/plain; charset="ISO-8859-15" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Cc: ksummit-discuss@lists.linuxfoundation.org, Dan Carpenter Subject: Re: [Ksummit-discuss] [CORE TOPIC] [nomination] Move Fast and Oops Things List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 2014-05-22 at 22:56 +0200, Geert Uytterhoeven wrote: > On Thu, May 22, 2014 at 10:31 PM, Dan Carpenter > wrote: > > On Thu, May 22, 2014 at 09:31:44AM -0700, Dan Williams wrote: > >> I agree that something like this is prickly once it gets entangled > >> with ABI concerns. But, I disagree with the speed argument... unless > >> you believe -staging has not increased the velocity of kernel > >> development? > > > > Staging is good because it brings more developers, but in many cases it > > is a slow down. Merged codes has stricter rules where you have to write > > reviewable patches. If there is a bug early in a patch series then you > > can't just fix it in a later patch, you need to redo the whole series. > > In theory... > > These days many fixes end up as separate commits in various subsystem > trees, due to "no rebase" rules and other regulations. No, pretty much in practise. I've no qualms about dropping a patch series if one of the git tree tests shows problems and, since I have a mostly linear tree, that means a rebase. I also don't believe in "preserving" history which is simply bug fixes that should have been in the series. Sometimes, if the fix took a while to track down, I might keep the separate patch for credit + learning, but most of the time I'd fold it into a commit and annotate the commit. James