From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: ksummit-discuss@lists.linuxfoundation.org,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [Ksummit-discuss] [CORE TOPIC] [nomination] Move Fast and Oops Things
Date: Thu, 22 May 2014 23:21:35 -0700 [thread overview]
Message-ID: <1400826095.2259.38.camel@dabdike.int.hansenpartnership.com> (raw)
In-Reply-To: <CAMuHMdW1KgvP9EpHfVykHEskdeDZ-p_zGy6AuY05-6Y-XEB2MQ@mail.gmail.com>
On Thu, 2014-05-22 at 22:56 +0200, Geert Uytterhoeven wrote:
> On Thu, May 22, 2014 at 10:31 PM, Dan Carpenter
> <dan.carpenter@oracle.com> wrote:
> > On Thu, May 22, 2014 at 09:31:44AM -0700, Dan Williams wrote:
> >> I agree that something like this is prickly once it gets entangled
> >> with ABI concerns. But, I disagree with the speed argument... unless
> >> you believe -staging has not increased the velocity of kernel
> >> development?
> >
> > Staging is good because it brings more developers, but in many cases it
> > is a slow down. Merged codes has stricter rules where you have to write
> > reviewable patches. If there is a bug early in a patch series then you
> > can't just fix it in a later patch, you need to redo the whole series.
>
> In theory...
>
> These days many fixes end up as separate commits in various subsystem
> trees, due to "no rebase" rules and other regulations.
No, pretty much in practise. I've no qualms about dropping a patch
series if one of the git tree tests shows problems and, since I have a
mostly linear tree, that means a rebase.
I also don't believe in "preserving" history which is simply bug fixes
that should have been in the series. Sometimes, if the fix took a while
to track down, I might keep the separate patch for credit + learning,
but most of the time I'd fold it into a commit and annotate the commit.
James
next prev parent reply other threads:[~2014-05-23 6:21 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-15 23:13 Dan Williams
2014-05-16 2:56 ` NeilBrown
2014-05-16 15:04 ` Chris Mason
2014-05-16 17:09 ` Andy Grover
2014-05-23 8:11 ` Dan Carpenter
2014-05-16 18:31 ` Randy Dunlap
2014-05-21 7:48 ` Dan Williams
2014-05-21 7:55 ` Greg KH
2014-05-21 9:05 ` Matt Fleming
2014-05-21 12:52 ` Greg KH
2014-05-21 13:23 ` Matt Fleming
2014-05-21 8:25 ` NeilBrown
2014-05-21 8:36 ` Dan Williams
2014-05-21 8:53 ` Matt Fleming
2014-05-21 10:11 ` NeilBrown
2014-05-21 15:35 ` Dan Williams
2014-05-21 23:06 ` Rafael J. Wysocki
2014-05-21 23:03 ` Dan Williams
2014-05-21 23:40 ` Laurent Pinchart
2014-05-22 0:10 ` Rafael J. Wysocki
2014-05-22 15:48 ` Theodore Ts'o
2014-05-22 16:31 ` Dan Williams
2014-05-22 17:38 ` Theodore Ts'o
2014-05-22 18:42 ` Dan Williams
2014-05-22 19:06 ` Chris Mason
2014-05-22 20:31 ` Dan Carpenter
2014-05-22 20:56 ` Geert Uytterhoeven
2014-05-23 6:21 ` James Bottomley [this message]
2014-05-23 14:11 ` John W. Linville
2014-05-24 9:14 ` James Bottomley
2014-05-24 19:19 ` Geert Uytterhoeven
2014-05-23 2:13 ` Greg KH
2014-05-23 3:03 ` Dan Williams
2014-05-23 7:44 ` Greg KH
2014-05-23 14:02 ` Josh Boyer
2014-05-21 23:48 ` NeilBrown
2014-05-22 4:04 ` Dan Williams
2014-05-21 7:22 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400826095.2259.38.camel@dabdike.int.hansenpartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=dan.carpenter@oracle.com \
--cc=geert@linux-m68k.org \
--cc=ksummit-discuss@lists.linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox