ksummit.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: James Bottomley <James.Bottomley@hansenpartnership.com>,
	Luis Rodriguez <mcgrof@gmail.com>,
	"ksummit-discuss@lists.linuxfoundation.org"
	<ksummit-discuss@lists.linuxfoundation.org>,
	Kyle McMartin <jkkm@jkkm.org>
Subject: Re: [Ksummit-discuss] [TECH TOPIC] Firmware signing
Date: Wed, 12 Aug 2015 19:22:00 +0100	[thread overview]
Message-ID: <11239.1439403720@warthog.procyon.org.uk> (raw)
In-Reply-To: <CALCETrV3LZu+e5Atwe2DUYUBhRnu-yEc-aguuco94jnPA2YYxg@mail.gmail.com>

Andy Lutomirski <luto@amacapital.net> wrote:

> > The top patch here:
> >
> >         http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=modsign-pkcs7-2
> >
> > allows demand loading of keys based on their SKID into a special keyring from
> > which they get erased after an arbitrary 3 minutes of existence.  This key can
> > then be used to verify a signature instead of using the primary system keyring
> > used for module signature checking.
> >
> > Building on this, a driver could have a SKID compiled into it which could then
> > be used to load a key for request_firmware() to use in verifying the blobs
> > that that driver requires.
> >
> 
> Who signs the vendor key?

From the arguments so far presented, the vendor - but possibly allowing the
linux-fimrware manager to sign in lieu if the admin of a machine running this
stuff allows it.

> Why are we bothering loading device vendor keys into a keyring in the
> first place?

Caching.  Some drivers need more than one firmware blob.

> Why not just have an API to request firmware either signed by a literal key
> provided by the driver *or* whatever keys the system trusts in general for
> firmware signing?

By "a literal key provided by the driver" I presume you mean that the parts of
the key (perhaps an X.509 cert) are actually compiled into the driver.  Yes we
could do this quite easily - key_create_or_update() will turn a binary key
blob into a struct key * that can then be used.  Do we want ~1.5K or more of
undiscardable data per key adding to each module that wants to load firmware,
particularly if it needs to carry several keys just in case one gets revoked?

Objections have been raised against using general keys for firmware signing.

David

  parent reply	other threads:[~2015-08-12 18:22 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-28 13:36 David Howells
2015-07-28 14:23 ` David Woodhouse
2015-07-28 16:55   ` Luis R. Rodriguez
2015-07-28 15:10 ` James Bottomley
2015-07-28 15:22   ` Andy Lutomirski
2015-07-28 15:31     ` James Bottomley
2015-07-28 16:05       ` Andy Lutomirski
2015-07-28 16:10         ` James Bottomley
2015-07-28 16:15           ` David Woodhouse
2015-07-28 16:35             ` Andy Lutomirski
2015-07-28 16:44             ` David Howells
2015-07-28 17:03               ` Andy Lutomirski
2015-07-28 19:19                 ` David Woodhouse
2015-07-28 19:31                   ` Andy Lutomirski
2015-07-28 19:43                     ` David Woodhouse
2015-07-28 22:03                     ` James Bottomley
2015-08-11 20:24                     ` David Howells
2015-08-11 21:56                       ` Andy Lutomirski
2015-08-11 22:03                         ` Luis R. Rodriguez
2015-08-12 18:22                       ` David Howells [this message]
2015-08-12 18:45                         ` David Woodhouse
2015-08-12 19:09                           ` Andy Lutomirski
2015-08-12 19:15                             ` James Bottomley
2015-08-12 19:25                               ` Andy Lutomirski
2015-08-12 19:43                                 ` James Bottomley
2015-08-12 19:45                                   ` Andy Lutomirski
2015-08-12 19:59                                     ` James Bottomley
2015-08-13  7:03                                       ` Jan Kara
2015-08-13 14:01                                         ` James Bottomley
2015-08-12 22:46                           ` David Howells
2015-08-12 22:51                             ` Andy Lutomirski
2015-08-12 19:06                         ` Andy Lutomirski
2015-08-12 22:39                         ` David Howells
2015-08-12 22:45                           ` Andy Lutomirski
2015-08-12 22:45                         ` David Howells
2015-08-12 22:47                           ` Andy Lutomirski
2015-07-28 16:18   ` David Howells
2015-07-28 16:42     ` James Bottomley
2015-07-28 17:05       ` Andy Lutomirski
2015-07-28 17:09         ` James Bottomley
2015-07-28 17:10           ` Andy Lutomirski
2015-07-29  2:00         ` James Morris
2015-07-28 16:58   ` Josh Boyer
2015-07-28 15:12 ` David Woodhouse
2015-07-28 18:47   ` Peter Jones
2015-07-28 19:14   ` David Howells
2015-07-28 19:52     ` Peter Jones
2015-07-28 16:17 ` David Howells
2015-07-28 16:59   ` James Bottomley
2015-07-28 19:11   ` David Howells
2015-07-28 19:34     ` Luis R. Rodriguez
2015-07-28 21:53     ` James Bottomley
2015-07-28 22:39     ` David Howells
2015-07-28 22:44       ` Andy Lutomirski
2015-07-29  8:39         ` David Woodhouse
2015-07-28 18:36 ` josh
2015-07-28 18:44   ` James Bottomley
2015-07-28 18:54     ` josh
2015-07-28 19:06       ` Luis R. Rodriguez
2015-07-28 21:38       ` Greg KH
2015-07-28 23:59         ` josh
2015-07-29  0:17           ` Greg KH
2015-07-29  9:37         ` David Woodhouse
2015-07-29 15:00           ` James Bottomley
2015-07-29 15:35             ` David Woodhouse
2015-07-29 16:38               ` James Bottomley
2015-07-29 17:32                 ` David Woodhouse
2015-07-29 23:39                   ` James Bottomley
2015-07-30  8:08                     ` David Woodhouse
2015-07-30 13:48                       ` James Bottomley
2015-07-30 14:21                         ` Heiko Stübner
2015-07-30 14:30                           ` James Bottomley
2015-07-30 15:01                         ` David Woodhouse
2015-07-30 16:17                           ` James Bottomley
2015-07-30 19:17                             ` David Woodhouse
2015-07-31 14:41                               ` Theodore Ts'o
2015-07-31 16:14                                 ` Tim Bird
2015-07-31 17:25                                   ` David Woodhouse
2015-07-30 16:24                           ` Tim Bird
2015-07-29 16:35             ` Josh Triplett
2015-07-29  8:29       ` David Woodhouse
2015-07-29 11:57       ` Mark Brown
2015-07-29 12:02         ` David Woodhouse
2015-07-29 12:24           ` Mark Brown
2015-07-28 19:23   ` David Woodhouse
2015-07-28 19:19 ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11239.1439403720@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=jkkm@jkkm.org \
    --cc=ksummit-discuss@lists.linuxfoundation.org \
    --cc=luto@amacapital.net \
    --cc=mcgrof@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox