Re: [Ksummit-discuss] [CORE TOPIC] Recruitment (Reviewers, Testers, Maintainers, Hobbyists)

[Jonathan Cameron <jic23@kernel.org>]

On 13 July 2015 17:28:25 BST, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>On Mon, Jul 13, 2015 at 04:33:31PM +0200, Jan Kara wrote:
>> On Mon 13-07-15 17:20:47, Dan Carpenter wrote:
>> > On Sun, Jul 12, 2015 at 07:28:23AM -0500, Josh Poimboeuf wrote:
>> > > I agree that the Reviewed-by tag doesn't apply here.  It
>communicates
>> > > patch approval, rather than review helpfulness.  That's why I
>proposed a
>> > > new tag from the patch author and/or maintainer.
>> > 
>> > I've lobbied for:
>> > 
>> > With-Fixes-from: xxx
>> > 
>> > It would only be given for actual bug fixes and not for complaining
>> > about the subject line, white space or spelling mistakes.
>> 
>> This seems like overengineering to me. I usually give a credit in the
>changelog
>> if I find someone's contribution big enough. Also a persistent
>reviewer will
>> eventually get his credit via Reviewed-by :). So I don't think yet
>another
>> tag is really necessary.
>
>I could get as many reviewed-by tags as I wanted...  I basically only
>write reviewed-by tags as a way of being nice to people sending
>patches.
>
>Lots of people give credit for fixes in the changlog like but it's more
>common to leave it out.  Also it's not searchable.
>
>This happened hours ago in staging.  Someone sent a buggy patch and
>reviewers spotted the bug but no one got credit.
>
>http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2015-July/072662.html
>http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2015-July/072668.html
>
>Imagine how special Patrick would feel if we gave him a nice
>"With-fix-from: Patrick Farrell <paf@cray.com>" tag.  :)  Also the
>other
>rule would be that only the first person to report the bug gets the
>credit (Sorry, Sudip).  The next version of the patch had a process
>problem which Sudip noticed as well but that still doesn't earn a
>with-fix-from tag.

I like this idea in principle. Not entirely sure if it will work perfectly in practice.

Likely that in high revision count series some earlier work will not get credit...
 Unless patch authors get to propose such tags as suggestions to the
 maintainer.  Preferably with description in the change log!  Guessing I am not the
 only maintainer who doesn't keep up with all the versions of some patches other
 than a quick controversy check!

>
>regards,
>dan carpenter
>
>_______________________________________________
>Ksummit-discuss mailing list
>Ksummit-discuss@lists.linuxfoundation.org
>https://lists.linuxfoundation.org/mailman/listinfo/ksummit-discuss

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.