From: Mateusz Guzik <mjguzik@gmail.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: oleg@redhat.com, brauner@kernel.org,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
linux-mm@kvack.org
Subject: Re: [PATCH v3 2/2] pid: only take pidmap_lock once on alloc
Date: Sun, 7 Dec 2025 10:21:35 +0100 [thread overview]
Message-ID: <CAGudoHFjrMsQaDzndo3sM1Jn_WROBrZ0PeQbU89-tDakLAOvew@mail.gmail.com> (raw)
In-Reply-To: <aTUq5bRdPNpup8GQ@casper.infradead.org>
On Sun, Dec 7, 2025 at 8:21 AM Matthew Wilcox <willy@infradead.org> wrote:
>
> On Sat, Dec 06, 2025 at 02:19:55PM +0100, Mateusz Guzik wrote:
> > - if (!pid)
> > + if (unlikely(!pid))
>
> Does this change anything? I was under the impression that gcc already
> treats !p as unlikely.
I don't know if gcc is guaranteed to act like that, most of my
experience is with clang which was rather inconsistent about it.
next prev parent reply other threads:[~2025-12-07 9:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-06 13:19 [PATCH v3 0/2] further damage-control lack of clone scalability Mateusz Guzik
2025-12-06 13:19 ` [PATCH v3 1/2] ns: pad refcount Mateusz Guzik
2025-12-06 13:19 ` [PATCH v3 2/2] pid: only take pidmap_lock once on alloc Mateusz Guzik
2025-12-07 7:21 ` Matthew Wilcox
2025-12-07 9:21 ` Mateusz Guzik [this message]
2025-12-07 10:37 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGudoHFjrMsQaDzndo3sM1Jn_WROBrZ0PeQbU89-tDakLAOvew@mail.gmail.com \
--to=mjguzik@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=oleg@redhat.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox