Re: [PATCH] mm/damon: modified damon_call_control from static to kmalloc

[SeongJae Park <sj@kernel.org>]

On Tue, 9 Dec 2025 21:20:42 +0900 JaeJoon Jung <rgbi3307@gmail.com> wrote:

> Hello, SeongJae,
> 
> Thank you for your detailed feedback.
> My patch has the advantage of removing the use of
> the damon_call_control.dealloc_on_cancel variable.

Thank you for keeping this conversation for enlightening me, Jaejoon.

Could you please elaborate why you think the removal is an advantage?  I
understand reducing code is good in general.  But that's only if the code is
unnecessary.  dealloc_on_cancel is there for real use case, so I don't clearly
see why it is an advantage.

Meanwhile I find the feature might look complicated, or not well documented.
Specifically, dealloc_on_cancel should be set on only dynamic-allocated
damon_call_control object, but that is not well documented on the kernel-doc
comments.  Are you saying removing it is an advantage because it makes reading
code easier?  If that's the case, how about improving the documentation?

Btw, please consider not doing "top posting" [1].

[1] https://subspace.kernel.org/etiquette.html#do-not-top-post-when-replying


Thanks,
SJ

[...]